Fix getAssetsIndex task for FG1.0 by zeng-github01 · Pull Request #1075 · MinecraftForge/ForgeGradle

zeng-github01 · 2026-05-18T12:22:45Z

@LexManos Please review it

LexManos · 2026-05-22T04:51:00Z

+    public static final OperatingSystem OPERATING_SYSTEM = getOs();
+    public static final SystemArch SYSTEM_ARCH = getArch();
+    public static final String HASH_FUNC = "MD5";
+    public static final String USER_AGENT = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11";


Do not run code formatters over existing code.
It makes your entire change set a pain to actually read/understand

I formatted it on a whim, do I need to undo it?

Yes, code changes should be actual changes not formatting. It makes it a pain to see what you actually changed.

LexManos · 2026-05-22T04:52:20Z

+    public static final String FERNFLOWER = "{CACHE_DIR}/minecraft/fernflower.jar";
+    public static final String EXCEPTOR = "{CACHE_DIR}/minecraft/exceptor.jar";
+    public static final String ASSETS = "{CACHE_DIR}/minecraft/assets";
+    public static final String JSONS_DIR = "{CACHE_DIR}/minecraft/versionJsons";


Don't use upper cases in directory names

This path was copied directly from FG 1.2, which allows resource files to be stored together with other versions of FG. Do you think it needs to be changed?

LexManos · 2026-05-22T23:40:07Z

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

zeng-github01 · 2026-05-23T06:26:00Z

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

buildscript {
    repositories {
        mavenCentral()
        maven { url uri('local-maven') }
        maven {
            name = "forge"
            url = "https://files.minecraftforge.net/maven"
        }
    }
    dependencies {
        classpath 'net.minecraftforge.gradle:ForgeGradle:1.0.3'
    }
}

apply plugin: 'forge'

sourceCompatibility = '1.7'
targetCompatibility = '1.7'

version = "1.0"
group = "org.Example"
archivesBaseName = "Example"

minecraft {
    version = "1.6.4-9.11.1.964"
    //Apply AccessTransformer here uncomment below
//    accessTransformer("")
}

repositories {
    maven { url "https://cursemaven.com" }
}

dependencies {
}

processResources {
    duplicatesStrategy = DuplicatesStrategy.INCLUDE

    inputs.property "version", project.version

    from(sourceSets.main.resources.srcDirs) {
        include 'mcmod.info'
        expand 'version': project.version
    }
    from(sourceSets.main.resources.srcDirs) {
        exclude 'mcmod.info'
    }
}

jar {
    manifest {
        attributes(
                "FMLCorePlugin": "com.example.MinecraftModifier",
                "FMLCorePluginContainsFMLMod": "true"
        )
    }
}

task deobfJar(type: Jar) {
    from sourceSets.main.output

    classifier = 'dev'
}



artifacts {
    archives deobfJar
}

This is a development package I packaged locally, similar to MDK 1.7.10. This is the build script it uses. It uses Gradle 4.

The version numbers might be inconsistent because the Gradle version wasn't upgraded in the PR. I remember seeing this PR with version 1.0.1

zeng-github01 · 2026-05-23T06:35:28Z

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

The script has been provided; I recall that setupWorkspace and build are both available.

LexManos · 2026-05-23T23:50:03Z

+import java.io.IOException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;


java.nio doesnt exist in java 6 Which is required to decompile the game correctly due to bugs in fernflower.
java.nio.file.Files was added in java 7
FG 1.2 works fine with this because it uses an updated Fernflower with stabilization

I'm considering whether to upgrade compatibility to Java 7 or 8. Java 6 is practically obsolete.

There are several other places that also mention the 1.7 API, but I don't know why they don't affect compilation.

They dont effect compilation because youre using the system java to compile. Which is probably java 8+

I'm considering whether to upgrade compatibility to Java 7 or 8. Java 6 is practically obsolete.

Yes, there isnt even a distro for modern macs. Which is what im running into for mavenizer.

But its not possible to bump the required java version until the fernflower issues i stated are fixed.

I've tested it locally, and directly upgrading the version didn't reveal any bugs. I've even compiled and run the mod using my fixed FG. So I want to know what the problem is.

LexManos · 2026-05-24T01:34:37Z

Alright, so needed to get a functional FG1.1 branch up and running.
So I took at stab at fixing the downloading of assets for that branch.
You can see how it should be done in my commit LexManos@367864a
The reason I haven't pushed to production is that it doesn't actually setup a 1.7.2-10.12.0.967 workspace correctly.

Part of my blocker is that sonatype has died, and thus the SpecialSource snapshot we use for deobf is gone.
Any chance you have a mirror/download for that versions?
The other issue is that java 7 does not have modern root authorities, so you have to run with a hybrid java 7 and 8 workspace.
I'm working on getting a solution to that, but I need to get a copy of the old SpecialSource to help me in that endevor.

Once I fix the Fernflower on Java 8 issue, it'll let me complete my current project of Mavenizer support for FG 1 & 2. Which means 1.6.4->1.12.2 will work on FG7. (Currently I have 1.8-1.12.2 working as they use a fixed FernFlower)

But, im off for a while. So if you can look into that and let me know that'd be great. Else i'll look into it when i get back home.

undo format

zeng-github01 · 2026-05-24T01:55:26Z

Sorry, I don't have this version of SpecialSource either. I found that there seems to be a 1.7.2 version of SpecialSource in the central Maven repository. Can't use this one?

LexManos · 2026-05-24T02:47:19Z

Sorry, I don't have this version of SpecialSource either. I found that there seems to be a 1.7.2 version of SpecialSource in the central Maven repository. Can't use this one?

Naw, there are behavioral differences between those versions that cause decompile to break

zeng-github01 · 2026-05-24T06:03:27Z

Naw, there are behavioral differences between those versions that cause decompile to break

That's terrible news.

zeng-github01 · 2026-05-24T06:10:34Z

@LexManos Could you recompile this specific version? I've found the corresponding commit.

md-5/SpecialSource@1addd1b

LexManos · 2026-05-24T06:19:55Z

Its one of these builds LexManos/SpecialSource@1addd1b...e1ab7c7
I'll grind through and check tomarrow.

zeng-github01 force-pushed the FG_1.0-assets-download branch from 954e0eb to 57c9ee0 Compare May 18, 2026 12:31

LexManos reviewed May 22, 2026

View reviewed changes

LexManos reviewed May 23, 2026

View reviewed changes

zeng-github01 added 2 commits May 24, 2026 09:41

Fix getAssetsIndex task

ef5f9c4

undo format

don't remove getAssetsIndexn task cache

b5cc10e

zeng-github01 force-pushed the FG_1.0-assets-download branch from 420c284 to b5cc10e Compare May 24, 2026 01:41

Uh oh!

Conversation

zeng-github01 commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LexManos commented May 22, 2026

Uh oh!

zeng-github01 commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeng-github01 commented May 23, 2026

Uh oh!

LexManos May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LexManos commented May 24, 2026

Uh oh!

zeng-github01 commented May 24, 2026

Uh oh!

LexManos commented May 24, 2026

Uh oh!

zeng-github01 commented May 24, 2026

Uh oh!

zeng-github01 commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LexManos commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zeng-github01 commented May 18, 2026 •

edited

Loading

zeng-github01 commented May 23, 2026 •

edited

Loading

LexManos May 23, 2026 •

edited

Loading

zeng-github01 commented May 24, 2026 •

edited

Loading